Add cli output for generic zkgroup keys to assist server configuration #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsunday
changed the title
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Contributor
|
@alexsunday Please accept my apologies for the delay here; although I would have preferred a more graceful closure to this pull request, I think we will ultimately decline this one because this tool is actually obsolete. We now use tools in the libsignal repository to generate these credentials. I'll follow up internally to provide a more precise link to those tools, and we'll also remove this tool from the server repository entirely. Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added output of generic zkgroup keys (public and private) to the command-line tool. The previous version only output the zkgroup service keys, which was insufficient for complete server configuration. This change makes it easier to generate and obtain all required zk keys during server initialization or setup.